Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide media if no cutout available #336

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented Nov 20, 2024

What does this change?

If a cutout was requested (e.g. for Comment cards) but there is no cutout available, this should default to toggle the hideImage option on instead of showing the trail image by default.

Trello ticket

How to test

Create a pre-release version and install to a facia-tool branch then run locally or deploy to the CODE environment to check that:

  • Comment cards with cutouts available still show the cutout
  • Comment cards without cutouts available default to hide the image. You should be able to untoggle this and revert to the trail image in the fronts tool
  • Other card behaviour should remain unchanged

Images

Accessibility

Deployment

  • Updated facia-tool to use latest version
  • Updated frontend to use latest version
  • Updated MAPI to use latest version
  • Updated Ophan to use latest version
  • Updated story-packages to use latest version
  • Updated apple-news to use latest version
  • Checked for other downstream dependencies (perhaps via snyk or github search)

@cemms1 cemms1 self-assigned this Nov 20, 2024
@gu-scala-library-release
Copy link
Contributor

@cemms1 has published a preview version of this PR with release workflow run #52, based on commit 151f147:

13.0.1-PREVIEW.cemms1hide-media-if-no-cutout.2024-11-20T1629.151f147a

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the cemms1/hide-media-if-no-cutout branch, or use the GitHub CLI command:

gh workflow run release.yml --ref cemms1/hide-media-if-no-cutout

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant