Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #80. The canonical container either comes from the FrontJson, or is the first container on the front.
Note that this PR contains two commits, the second specifies the edition network fronts' canonical containers as well. While we wait for the tools to support this feature, the network front canonical containers can be hard-coded. This commit can be rolled back when the tools support is in place and the correct JSON is actually coming through.
Don't merge this yet, it's open for comment/review, I'm going to test it by integrating it with MAPI.
Note that I'm assured there can never be a front with 0 containers. I've raised a an issue (#83) suggesting we capture this by making that a
NonEmptyList
. That would remove the need for the"no collections"
fallback string.