Migrate CI from TeamCity to GitHub Actions #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done using guardian/actions-riff-raff which is configured in the build.yml workflow file.
Previously this was being done by node-riffraff-artifact
akash1810
reviewed
Sep 15, 2023
As yarn comes pre-installed in the environment
To ensure different versions of dependencies are not installed during CI
|
UPDATE: I have added the |
Since making this change I tested by successfully deploying to PROD (there is no CODE stage), verifying that the cloudformation template has been replaced in AWS, and testing the lambda function in AWS, which runs successfully. |
|
As part of rollout I've rebased the open dependabot PRs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This migrates CI from TeamCity to GitHub Actions.
Previously the deprecated
node-riffraff-artifactmodule was used to compress the bundled file into a .zip file and upload files to Riff-Raff. This PR moves to using the Actionactions-riffraffinstead and does the zipping manually, as this Action does not support compression.Trello card is here.
Further work
Node version 12 is defined in the
.nvmrc, and version 14 is defined in cloudformation as the lambda runtime environment. Node 14 will be deprecated for AWS lambdas on Nov 27, 2023, so this will need to be upgraded, as well as upgrading the application node version.How to test
This has been tested by comparing the zip files from a previous successful build to a new build.
The size of the zip files are slightly different, but downloading each file and running
unzip -l front-press-monitor.zipon the command line confirms that the unzippedindex.jsfiles are the same size.This has also been tested by testing the lambda function in AWS - it ran successfully, as confirmed by these logs:
Rollout
UPDATE: I have added the cloudformation.yml template to the files uploaded to riff-raff (previously this would have been done manually) and have configured the riff-raff.yaml file to enable riff-raff to deploy this.