Skip to content

Commit

Permalink
Move Email Newsletters To facia-rendering (#27467)
Browse files Browse the repository at this point in the history
This is the only page using the old `rendering` stack. If we move it to one of the new stacks we can remove the `rendering` stack.

The four new stacks are `article-rendering`, `facia-rendering`, `tag-page-rendering` and `interactive-rendering`. This page is most similar to a front, so this change moves it to that stack. The alternative would be to create a new stack just for this page.
  • Loading branch information
JamieB-gu authored Sep 10, 2024
1 parent a45df6c commit 688f109
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion common/app/common/configuration.scala
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ class GuardianConfiguration extends GuLogging {
}

object rendering {
lazy val baseURL = configuration.getMandatoryStringProperty("rendering.baseURL")
lazy val articleBaseURL = configuration.getMandatoryStringProperty("article-rendering.baseURL")
lazy val faciaBaseURL = configuration.getMandatoryStringProperty("facia-rendering.baseURL")
lazy val tagPageBaseURL = configuration.getMandatoryStringProperty("tag-page-rendering.baseURL")
Expand Down
2 changes: 1 addition & 1 deletion common/app/renderers/DotcomRenderingService.scala
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ class DotcomRenderingService extends GuLogging with ResultWithPreconnectPreload

val dataModel = DotcomNewslettersPageRenderingDataModel.apply(page, newsletters, request)
val json = DotcomNewslettersPageRenderingDataModel.toJson(dataModel)
post(ws, json, Configuration.rendering.baseURL + "/EmailNewsletters", CacheTime.Facia)
post(ws, json, Configuration.rendering.faciaBaseURL + "/EmailNewsletters", CacheTime.Facia)
}

def getImageContent(
Expand Down
1 change: 0 additions & 1 deletion common/conf/env/DEVINFRA.properties
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ pa.rugby.api.key=none

# DCR
rendering.endpoint=http://localhost:3030
rendering.baseURL=http://localhost:3030
article-rendering.baseURL=http://localhost:3030
facia-rendering.baseURL=http://localhost:3030
tag-page-rendering.baseURL=http://localhost:3030
Expand Down

0 comments on commit 688f109

Please sign in to comment.