Provide DCAR JSON For Galleries #27612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when requesting JSON for a gallery, `forceDCR` is ignored. This is because the request has to be categorised as a "remote render" for DCAR JSON to be provided. However, this JSON is provided by frontend, not DCAR, so it's not accurate to call it a "remote render". This change creates a separate case, apart from the "remote render" logic, to handle DCAR JSON for galleries.
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @JamieB-gu 12 minutes and 8 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @JamieB-gu 13 minutes and 13 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when requesting JSON for a gallery,
forceDCRis ignored. This is because the request has to be categorised as a "remote render" for DCAR JSON to be provided. However, this JSON is provided by frontend, not DCAR, so it's not accurate to call it a "remote render".This change creates a separate case, apart from the "remote render" logic, to handle DCAR JSON for galleries.
Note: Prior to #27556 it would still have been possible to get DCAR JSON, because
forceDCRwould have categorised the request as a "remote render". However, as mentioned above, this is not a "remote render", so the solution is to make the change here rather than reverting or altering that PR.