Fixes image delete infinite polling after delete.

Recognises soft deleted as a deleted. Returns promise to that it can be waited on.
guardian · Dec 29, 2024 · db7c10c · db7c10c
1 parent 7f11ad8
commit db7c10c
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/kahuna/public/js/components/gr-delete-image/gr-delete-image.js b/kahuna/public/js/components/gr-delete-image/gr-delete-image.js
@@ -14,12 +14,19 @@ deleteImage.controller('grDeleteImageCtrl', [
         this.$onInit = () => {
           function pollDeleted (image) {
               const findImage = () => mediaApi.find(image.data.id).then(
-                  () => $q.reject(),
+                  (r) => {
+                    if (r.data.softDeletedMetadata) {
+                      // resolve when image has been soft deleted.
+                      return $q.resolve();
+                    } else {
+                      return $q.reject();
+                    }
+                  },
                   // resolve when image cannot be found, i.e. image has been deleted.
                   () => $q.resolve()
               );
 
-              apiPoll(findImage);
+              return apiPoll(findImage);
           }
 
           ctrl.deleteImage = function (image) {