move 'reapable' eligibility logic into common-lib (along with supporting classes)
#4143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2023
andrew-nowak
approved these changes
Sep 28, 2023
…r use in `thrall` (along with supporting classes)
twrichards
force-pushed
the
reaper/move-is-reapable-to-common
branch
from
84c9eec to
c87b0ff
Compare
prout-bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
and removed
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
labels
|
Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (merged by @twrichards 26 minutes and 23 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/DrGAH8Y0/893-turn-on-the-reaper
Similar to what was done as part of the temporary #4066 (reverted in #4097) we need (in upcoming PR) to query for reapabality in
thralland as such this PR moves the 'reapable' eligiblity logic frommedia-apitocommon-libalong with supporting classes. It's in its own PR to make it easier to review.This should be a no-op, and to test you can use the
is:reapablesearch before and after this branch is deployed.IMPORTANT
This involves moving the
persistence.identifierandpersistence.collectionsfrommedia-api.confup tocommon.confotherwise all microservices (exceptmedia-api) will fail to start. This has already been done at the Guardian (bothTESTandPROD) a while back as part of #4066 (and left in common).