run CI GHA on pull_request so that external contributors benefit from CI
#4148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om CI and limit `push` based trigger to `main` branch only to avoid duplicate workflow runs (wasteful)
twrichards
force-pushed
the
gha/CI-for-PRs
branch
from
103e202 to
e5afb3f
Compare
prout-bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
Seen-on-auth
and removed
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
labels
|
Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (merged by @twrichards 12 minutes and 7 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following/tweaking #4146 - we do need to trigger the unified
CIGHA based onpull_request* and not just 'all branches' since this doesn't include branches on forks (understandably) and I imagine our external contributors benefit from the CI checks (compilation, tests etc.) on their PRs.To complement the above, we limit
pushbased trigger tomainbranch only to avoid duplicate workflow runs (wasteful) as well as branches starting with pr (i.e. those created bydev/script/push-pr.sh).* this does have the unfortunate downside of building the hidden
pull/XXX/mergebranch, which is actually a preview of what the merge would look like rather than the branch the PR has been raised from - whilst isn't normally an issue but can on occasion cause pernicious problems, so would normally avoid it - but alas its necessary here. You can see an example from this PR's workflow run...