No error logging for unsupported file type #4234
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Refactors the
updateUploadStatusTable
to throw the exception to the upload operation (where the upload failed)The
recover
onattemptToProcessIngestedFile
has a separate case block forUnsupportedMimeType
exceptions so that:How should a reviewer test this change?
Upload a non-image file and check the logs for a "File has unsupported mime type" entry.
How can success be measured?
Less errors in the logs. Able to see which unsupported file types are often uploaded and by whom
Who should look at this?
Tested? Documented?