Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make transparency of crop gutters 50% to make them less 'opaque' #4342

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

twrichards
Copy link
Contributor

@twrichards twrichards commented Oct 1, 2024

#4331 added crop gutters under certain scenarios, and we've since been testing with a subset of users (see #4336) and have received the following feedback...

I find the diagonal stripes obscure the sides of the image too much - I can't see what's underneath them to decide if I want to reduce my 5:3 crop

The stripes are white, but with mix-blend-mode: difference which attempts to invert the colour below, however depending on the colour/darkness below this can appear too 'opaque'...

...so this PR is a quick fix to reduce the transparency to 50% (opacity: 0.5) - with hopefully a PR for configurable per-image transparency slider in #4341 - proving a bit fiddly so want to get this one-liner improvement out first, it might even suffice (hehe @paperboyo)

@twrichards twrichards requested review from a team as code owners October 1, 2024 08:44
@twrichards twrichards enabled auto-merge October 1, 2024 08:50
@prout-bot
Copy link

Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (merged by @twrichards 11 minutes and 34 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants