Upgrades to syntax and types to prepare for scala 2.13 upgrade #4355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-nowak
force-pushed
the
an/scala2.13-syntax
branch
from
71c3ab9 to
20319c8
Compare
andrew-nowak
force-pushed
the
an/scala2.13-syntax
branch
2 times, most recently
from
5b64b97 to
7ffc7db
Compare
andrew-nowak
changed the base branch from
main
to
an/kcl-akka-stream-sonatype
andrew-nowak
force-pushed
the
an/kcl-akka-stream-sonatype
branch
from
a573f37 to
0371ee2
Compare
the checker can't see that the two Some cases have opposite predicates, it's simply upset that there isn't a wildcard Some case
.right is now heavily deprecated; the syntax for .right.value is now .value
|
Seen on image-loader, thrall, auth, metadata-editor (merged by @andrew-nowak 8 minutes and 41 seconds ago) Please check your changes! |
|
Seen on leases, cropper, kahuna, media-api (merged by @andrew-nowak 8 minutes and 46 seconds ago) Please check your changes! |
|
Seen on collections (merged by @andrew-nowak 8 minutes and 50 seconds ago) Please check your changes! |
|
Seen on usage (merged by @andrew-nowak 8 minutes and 56 seconds ago) Please check your changes! |
1 similar comment
|
Seen on usage (merged by @andrew-nowak 8 minutes and 56 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Lots of updates to deprecated syntax and classes involved in the Scala 2.13 upgrade. Go commit-by-commit for related changes with (very brief!) descriptions of what's changed
How should a reviewer test this change?
How can success be measured?
Who should look at this?
Tested? Documented?