add defaultCropType param #4357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-nowak
approved these changes
Oct 29, 2024
|
Seen on media-api (merged by @dblatcher 8 minutes and 41 seconds ago) Please check your changes! |
prout-bot
added
Seen-on-auth
Seen-on-kahuna
Seen-on-thrall
and removed
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
labels
|
Seen on auth, thrall, kahuna (merged by @dblatcher 8 minutes and 46 seconds ago) Please check your changes! |
|
Seen on cropper, usage (merged by @dblatcher 8 minutes and 56 seconds ago) Please check your changes! |
prout-bot
added
Seen-on-leases
Seen-on-collections
and removed
Pending-on-leases
Pending-on-collections
labels
|
Seen on collections, leases (merged by @dblatcher 8 minutes and 59 seconds ago) Please check your changes! |
|
Seen on image-loader (merged by @dblatcher 9 minutes and 6 seconds ago) Please check your changes! |
|
Seen on metadata-editor (merged by @dblatcher 9 minutes and 14 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a
defaultCropTypeparam to kahuna's search, image and crop pages and validates and stores it in the same way as the existingcropTypeparam.The
defaultCropTypeis used to set what type of crop to initially set the on the crop window. If the param is not set, this will default to 'landscape', (being defined asdefaultCrop) as currentlyHow should a reviewer test this change?
run locally, open:
https://media.local.dev-gutools.co.uk/search?nonFree=true&defaultCropType=freeform
choose an image, click the 'crop' button
the crop UI should have "freeform" selected instead of "landscape"
How can success be measured?
The purpose is to allow application that use a Grid window to specify the "preferred" crop type, without preventing user selecting other crops.
In particular, the request is for Gallery Articles in composer - when adding images, they should default to freeform (which will start as a full frame crop), but users should be able to select other, existing crops if desired.
Who should look at this?
Tested? Documented?