add automatic image type detection #4363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
code looks wonderful to me, I haven't got any suitable images to test it with, but it's deployed to TEST as I think @paperboyo would like to give it a spin
common-lib/src/main/scala/com/gu/mediaservice/lib/cleanup/InsertGuardianImageType.scala
Outdated
Show resolved
Hide resolved
| case DigitalSourceType("compositeSynthetic") => Illustration | ||
| // unknown | ||
| case other => | ||
| logger.warn(s"Unexpected Iptc4xmpExt:DigitalSourceType value: $other. Consider adding a case for this value to DigitalSourceType.scala") |
Comment on lines
+85
to
+90
| /* TODO in scala 2.13: | ||
| name match { | ||
| case s"http://cv.iptc.org/newscodes/digitalsourcetype/$value" => | ||
| Some(value) | ||
| case _ => None | ||
| */ |
Co-authored-by: Tom Richards <[email protected]>
prout-bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
Seen-on-usage
Seen-on-kahuna
Seen-on-image-loader
Seen-on-cropper
Seen-on-metadata-editor
and removed
Pending-on-cropper
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-usage
Pending-on-kahuna
labels
|
Seen on usage, image-loader, metadata-editor, cropper, kahuna (merged by @andrew-nowak 7 minutes and 40 seconds ago) Please check your changes! |
prout-bot
added
Seen-on-auth
Seen-on-thrall
and removed
Pending-on-auth
Pending-on-thrall
labels
|
Seen on auth, thrall (merged by @andrew-nowak 7 minutes and 54 seconds ago) Please check your changes! |
prout-bot
added
Seen-on-media-api
Seen-on-collections
and removed
Pending-on-media-api
Pending-on-collections
labels
|
Seen on media-api (merged by @andrew-nowak 8 minutes ago) Please check your changes! |
|
Seen on collections, media-api (merged by @andrew-nowak 8 minutes ago) Please check your changes! |
|
Seen on leases (merged by @andrew-nowak 9 minutes and 50 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Detect the image type (according to the Guardian vocabulary) from the Digital Source Type (IPTC vocab) when applicable.
How should a reviewer test this change?
How can success be measured?
Who should look at this?
Tested? Documented?