Upgrade to recent libthrift #4365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only common-lib depends on libthrift, I think this override was copied accidentally, and then not bumped when common-lib's was
libs now bring in uptodate libthrift, no need for override
bryophyta
approved these changes
Nov 13, 2024
prout-bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
and removed
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
labels
|
Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (merged by @andrew-nowak 9 minutes and 38 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Our dependencies now bring in recent versions of libthrift, so remove the dependencyOverrides which were keeping us stuck to older versions.
This PR should fix 3 "high" vulnerabilities on snyk.
How should a reviewer test this change?
Deploy to TEST and check that all functionality performs as previously.
The only libthrift usage I'm aware of is in the Guardian-specific usage stream - content updates arriving from Crier will be in the thrift format, and we'll need to deserialize them. Try adding some images to draft Composer pieces, and ensure that the pending usage arrives, and is removed when removed from the Composer piece, etc.
How can success be measured?
Who should look at this?
Tested? Documented?