upgrade node from 16 to 20 #4380
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` from the bundle/zip since v2 sdk is no longer provided at runtime (v3 is, upgrading to which is beyond the scope of this change)
twrichards
force-pushed
the
update-node
branch
from
037f5ee to
8baf1bf
Compare
|
Tested on Seems to work when run manually |
andrew-nowak
approved these changes
Dec 5, 2024
prout-bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
and removed
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
labels
|
Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (merged by @twrichards 8 minutes and 43 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades to node20 for the whole project, and doesn't seem to cause problems building the client side, but was mainly for the benefit of...
image-counter-lambdaWhich required stopping excluding
aws-sdkfrom the bundle/zip - since v2 aws-sdk is no longer provided at runtime, v3 is, upgrading to which is beyond the scope of this change).The corresponding bump to the lambda runtime is in https://github.com/guardian/editorial-tools-platform/pull/827