make the QM interface clearer

small refactor to the way the custom qm event string is constructed in the cancellation journey
guardian · Nov 7, 2024 · b5d8d62 · b5d8d62
1 parent 36ea865
commit b5d8d62
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 7 deletions.
diff --git a/client/components/mma/cancel/CancellationJourneyFunnel.tsx b/client/components/mma/cancel/CancellationJourneyFunnel.tsx
@@ -37,12 +37,19 @@ export const CancellationJourneyFunnel = () => {
 	const productTypeKey = productType.productType;
 
 	const possiblePaidPlan = productDetail.subscription.currentPlans[0];
-	const qmEventString = `cancellation start | ${productType.friendlyName}${
-		isPaidSubscriptionPlan(possiblePaidPlan)
-			? ` | billing period: ${possiblePaidPlan.billingPeriod}`
-			: ''
-	}`;
-	window.QuantumMetricAPI?.sendEvent(184, 0, qmEventString);
+	const qmEventId = 184;
+	const qmIsConversionEvent = 0;
+	const qmEvent = [
+		'cancellation start',
+		productType.friendlyName,
+		isPaidSubscriptionPlan(possiblePaidPlan) &&
+			`billing period: ${possiblePaidPlan.billingPeriod}`,
+	].filter(Boolean);
+	window.QuantumMetricAPI?.sendEvent(
+		qmEventId,
+		qmIsConversionEvent,
+		qmEvent.join(' | '),
+	);
 
 	if (
 		!routerState?.dontShowOffer &&

diff --git a/shared/globals.ts b/shared/globals.ts
@@ -28,7 +28,12 @@ export interface Globals extends CommonGlobals {
 	stripeKeyDefaultCurrencies?: StripePublicKeySet;
 }
 interface QuantumMetricAPIPartial {
-	sendEvent: (param1: number, param2: number, event: string) => void;
+	sendEvent: (
+		eventId: number | string,
+		conversion?: number | boolean,
+		eventValue?: number | string,
+		attributes?: Record<string, string | boolean | number | undefined>,
+	) => void;
 }
 declare global {
 	interface Window {