Upgrade to react 18 rendering api #1246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewHEguardian
force-pushed
the
ahe/use-react-18-rendering-api
branch
from
1cea47d to
0f4cabe
Compare
KentGrm
previously approved these changes
Nov 22, 2023
| @@ -103,7 +103,8 @@ describe('Holiday stops', () => { | |||
|
|
|||
| cy.findByText('No issues occur during selected period').should('exist'); | |||
|
|
|||
| cy.get('@product_detail.all').should('have.length', 1); | |||
| // ToDo: why is this being called more times? | |||
There was a problem hiding this comment.
Have you worked this out yet?
mxdvl
reviewed
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Upgrade to using react 18 rendering API -
createRootsee docs. We've been on React 18 for a while but running as if React 17. This will remove the console message seen below:How to test
Site behaves as expected, no regressions in Cypress tests, Chromatic etc...
See Risks section for what happened...
How can we measure success?
Have we considered potential risks?
Had to add
flushSyncaround an event handler inHolidayCalendarTables.tsxto get HolidayStop Cypress to pass. The component behaved normally when manually testing but the state was not updating correctly when running in Cypress, I think because of the improved batching in React 18Image of Cypress test failing without
flushSync, dates should be from 9/2 to 11/2 but the state is set with 9/2 to 9/2Images
Accessibility