Refactor to use a more meaningful name

guardian · Mar 15, 2024 · b48feec · b48feec
1 parent 67f7fb5
commit b48feec
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/typescript/src/feast/pubsub/pubsub.ts b/typescript/src/feast/pubsub/pubsub.ts
@@ -9,10 +9,11 @@ import { HTTPResponses } from "../../models/apiGatewayHttp";
 
 export async function handler(request: APIGatewayProxyEvent): Promise<APIGatewayProxyResult>  {
     console.log(`[34ef7aa3] ${JSON.stringify(request)}`)
-    return processEvent()(request)
+    const handler = buildHandler()
+    return handler(request)
 }
 
-export function processEvent(
+export function buildHandler(
     sendMessageToSqs: (queueUrl: string, message: AppleSubscriptionReference) => Promise<PromiseResult<Sqs.SendMessageResult, AWSError>> = sendToSqs
 ): (request: APIGatewayProxyEvent) => Promise<APIGatewayProxyResult> { 
     return async (request: APIGatewayProxyEvent) => {

diff --git a/typescript/tests/feast/pubsub/pubsub.test.ts b/typescript/tests/feast/pubsub/pubsub.test.ts
@@ -1,7 +1,7 @@
 import { StatusUpdateNotification } from "../../../src/pubsub/apple";
 import Mock = jest.Mock;
 import { APIGatewayProxyEvent } from "aws-lambda";
-import { processEvent } from "../../../src/feast/pubsub/pubsub";
+import { buildHandler } from "../../../src/feast/pubsub/pubsub";
 import { HTTPResponses } from "../../../src/models/apiGatewayHttp";
 
 describe("The Feast Apple pubsub", () => {
@@ -80,7 +80,9 @@ describe("The Feast Apple pubsub", () => {
 
         const expectedSubscriptionReferenceInSqs = {receipt: "TEST"};
 
-        return processEvent(mockSqsFunction)(input).then(result => {
+        const handler = buildHandler(mockSqsFunction)
+
+        return handler(input).then(result => {
             expect(result).toStrictEqual(HTTPResponses.OK);
             expect(mockSqsFunction.mock.calls.length).toEqual(1);
             expect(mockSqsFunction.mock.calls[0][1]).toStrictEqual(expectedSubscriptionReferenceInSqs);