Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node to v20.11.1 (Iron) #1376

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Update Node to v20.11.1 (Iron) #1376

merged 1 commit into from
Mar 4, 2024

Conversation

michaelbjacobson
Copy link
Contributor

Node v14 is now EOL, and AWS will be removing all support for it soon. This PR upgrades Node to v20.11.1, which is the official recommended version for LTS at the time of writing.

tomwadeson
tomwadeson approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@tomwadeson tomwadeson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! But take my +1 with a grain of salt. Not much experience with TS, so unaware of wider impact of this change (with a bump that large in Scala, I'd have expected to have to bump some dependencies too!)

@michaelbjacobson
Copy link
Contributor Author

michaelbjacobson commented Feb 29, 2024 •
edited
Loading

Cool! But take my +1 with a grain of salt. Not much experience with TS, so unaware of wider impact of this change (with a bump that large in Scala, I'd have expected to have to bump some dependencies too!)

@tomwadeson I assumed the same, but there's a fairly comprehensive suite of TypeScript unit tests, and the update hasn't caused any failures, or even warnings!

@michaelbjacobson michaelbjacobson merged commit 033f002 into main Mar 4, 2024
1 check passed
@shtukas shtukas deleted the mj/upgrade-node-version branch March 22, 2024 07:58
@tjmw tjmw mentioned this pull request Apr 19, 2024
Merged
4 tasks
@tjmw tjmw mentioned this pull request Apr 29, 2024
Merged
4 tasks
@tjmw tjmw mentioned this pull request May 13, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomwadeson tomwadeson tomwadeson approved these changes

@dskamiotis dskamiotis Awaiting requested review from dskamiotis

@shtukas shtukas Awaiting requested review from shtukas

@SarahJessica SarahJessica Awaiting requested review from SarahJessica

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbjacobson @tomwadeson