Mj/pipe existing cfn through cdk #1388
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, I like the incremental PR approach |
AndreaDiotallevi
approved these changes
Mar 11, 2024
tjmw
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Nice, this looks good to me!
Only because Tom Wadeson has spent more time in this repo recently than the rest of us, but I wonder if it's worth waiting for his 👍 when he's back tomorrow.
This is the next step in gradually moving over to CDK for the entire project.
Yeah that'd be great! I reckon that's probably work for down the line after the Feast specific stuff has been completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uploads the existing (YAML) CFN template via GuCDK. This is the next step in gradually moving over to CDK for the entire project.