Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new global secondary index with platform, to be used by revalidate lambda #1410

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

tjmw
Copy link
Member

@tjmw tjmw commented Mar 19, 2024

What does this change?

When querying for records to revalidate with Apple, we want to exclude Feast records (see #1409). This requires a new index (really I want to change to the existing index, but that isn't possible, so I'll add the new index then remove the old one when it's no longer used).

How to test

Deploy to CODE, see the new index in the Dynamo console.

I've also verified it's usable by #1409.

How can we measure success?

Have we considered potential risks?

Images

Accessibility

tjmw added 3 commits March 19, 2024 13:19
So that we can filter on it.
Editing the existing index failed with:
Resource handler returned message: "Cannot update GSI's properties other
than Provisioned Throughput and Contributor Insights Specification. You
can create a new GSI with a different name." (RequestToken:
b8bf0056-d503-81c6-ff7e-2801e104abed, HandlerErrorCode: InvalidRequest)
@tjmw tjmw marked this pull request as ready for review March 20, 2024 09:45
@tjmw tjmw merged commit fb5eec0 into main Mar 20, 2024
1 check passed
@tjmw tjmw deleted the tw/add-new-global-secondary-index-with-platform branch March 20, 2024 10:33
tjmw added a commit that referenced this pull request Mar 20, 2024
In #1410 a new index was added to replace the one removed here (it's the
same, but also includes the platform). Since #1409 we've been using the
new index, so now the old index can be removed.
tjmw added a commit that referenced this pull request Mar 21, 2024
In #1410 a new index was added to replace the one removed here (it's the
same, but also includes the platform). Since #1409 we've been using the
new index, so now the old index can be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants