Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add apple feast pubsub secret to cloudformation #1413

Merged
merged 2 commits into from
Mar 20, 2024
Merged

add apple feast pubsub secret to cloudformation #1413

merged 2 commits into from
Mar 20, 2024

Conversation

michaelbjacobson
Copy link
Contributor

@michaelbjacobson michaelbjacobson commented Mar 20, 2024 •
edited
Loading

Adds FeastApplePubSubSecret param and sets its value as an environment variable in the Feast pubsub lambda.

@michaelbjacobson michaelbjacobson marked this pull request as ready for review March 20, 2024 11:26
tjmw
tjmw approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@tjmw tjmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@michaelbjacobson michaelbjacobson merged commit 308f67b into main Mar 20, 2024
1 check passed
@shtukas shtukas deleted the mj/add-secret-for-feast-pubsub-lambda branch March 22, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjmw tjmw tjmw approved these changes

@tomwadeson tomwadeson Awaiting requested review from tomwadeson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbjacobson @tjmw