Feast product name should be FeastInAppPurchase
in soft-opt-in queue
#1414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
The soft-opt-in consents for Feast IAPs are different from other IAPs. In the soft-opt-in-consent-setter lambda the config has been updated to specify the new consents, but that lambda needs to be able to distinguish Feast IAPs from others. So in this PR we start providing a different productName (
FeastInAppPurchase
) for Feast events.How to test
I've extended and run the Jest tests. I'll also deploy to CODE and test there.
Update: I've tested in CODE. There's something going on with the cross account role and permissions to add to the queue so the lambda invocation errors, but I logged the message which would be added to the queue and it looks correct for both non-Feast and Feast:
How can we measure success?
Have we considered potential risks?
Images
Accessibility