Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feast product name should be FeastInAppPurchase in soft-opt-in queue #1414

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

tjmw
Copy link
Member

@tjmw tjmw commented Mar 20, 2024

What does this change?

The soft-opt-in consents for Feast IAPs are different from other IAPs. In the soft-opt-in-consent-setter lambda the config has been updated to specify the new consents, but that lambda needs to be able to distinguish Feast IAPs from others. So in this PR we start providing a different productName (FeastInAppPurchase) for Feast events.

How to test

I've extended and run the Jest tests. I'll also deploy to CODE and test there.

Update: I've tested in CODE. There's something going on with the cross account role and permissions to add to the queue so the lambda invocation errors, but I logged the message which would be added to the queue and it looks correct for both non-Feast and Feast:

Screenshot 2024-03-20 at 17 11 23

How can we measure success?

Have we considered potential risks?

Images

Accessibility

Copy link
Contributor

@tomwadeson tomwadeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! And easy to extend when Platform.AndroidFeast comes along. 👍

@tjmw
Copy link
Member Author

tjmw commented Mar 20, 2024

And easy to extend when Platform.AndroidFeast comes along.

Yeah I think so! I guess that'll map to FeastInAppPurchase too, so hopefully pretty much a one line change.

@tjmw tjmw merged commit 77c8ed0 into main Mar 21, 2024
1 check passed
@tjmw tjmw deleted the tw/distinct-feast-product-name-for-feast-soft-opt-ins branch March 21, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants