Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SonarAnalyzer.CSharp from 10.3.0.106239 to 10.4.0.108396 #636

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 23, 2024

Bumps SonarAnalyzer.CSharp from 10.3.0.106239 to 10.4.0.108396.

Release notes

Sourced from SonarAnalyzer.CSharp's releases.

10.4

Improvements

In this release, we have added support for test density and metrics at the individual file level. You can now view the number of unit tests, as well as details on skipped tests, failed tests, and test duration, from all supported coverage tools (xUnit, MsTest, and nUnit).

Additionally, we have significantly optimized memory allocation, resulting in memory usage reduction during registration.

False Positive

  • NET-868 - Fix S1854 FP: Don't raise when inner finally assignment is used to outer block
  • NET-865 - Fix S1172 FP: Parameter used as extension delegate target
  • NET-863 - Fix S1172 FP: Don't report on partial method parameters
  • NET-862 - Fix S1854 FP: Don't raise in catch when variable is used in following catch
  • NET-857 - Fix S3655 FP: Types with implicit conversion operator
  • NET-836 - Fix S1854 FP: Value used after catch

False Negative

  • NET-798 - Fix S1854 FN: Support &&, ||, ?? and ??=

Task

  • NET-763 - Update RSPEC before 10.4 release
Commits
  • 6e42b50 NET-891 Unit test import: add import support for nunit projects logging trx
  • 8acb7aa NET-763 Update RSPEC before 10.4 release
  • d00f951 NET-808 Update NuGet packages description for the analyzers
  • 44b2f5e NET-887 Unit test import: fix mapping in case of wrong casing
  • 02ed338 NET-886 XUnit fix mapping issue on explicit DisplayName
  • 831d94f NET-878 Rename Helper classes
  • af3f528 NET-868 Fix S1854 FP: Don't raise when inner finally assignment is used to ou...
  • 852b0ee NET-881 Log debug message on failed test mapping in XmlTestReportParser
  • 00ecc1e NET-879 Cleanup EditorConfigGenerator
  • e02c25d NET-865 S1172 FP: Parameter used as extension delegate target
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @guibranco.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by Sourcery

Update SonarAnalyzer.CSharp from 10.3.0.106239 to 10.4.0.108396.

Bug Fixes:

  • Fix false positives for S1854, S1172, and S3655.
  • Fix false negative for S1854.

Enhancements:

  • Add support for test density and metrics at the individual file level.
  • Optimize memory allocation, reducing memory usage during registration.

Tests:

  • Add import support for NUnit projects logging trx files.
  • Fix mapping issues for unit tests with wrong casing or explicit DisplayNames.

@dependabot dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file nuget packages labels Dec 23, 2024
@dependabot dependabot bot requested a review from guibranco December 23, 2024 14:25
Copy link

korbit-ai bot commented Dec 23, 2024

By default, I don't review pull requests opened by bots. If you would like me to review this pull request anyway, you can request a review via the /korbit-review command in a comment.

Copy link

sourcery-ai bot commented Dec 23, 2024

Reviewer's Guide by Sourcery

This pull request updates the SonarAnalyzer.CSharp NuGet package from version 10.3.0.106239 to 10.4.0.108396. This update includes improvements to test density metrics, memory allocation optimizations, several false positive and false negative fixes, and updated documentation.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated the SonarAnalyzer.CSharp NuGet package version.
  • Bumped SonarAnalyzer.CSharp from 10.3.0.106239 to 10.4.0.108396
Directory.Packages.props

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

coderabbitai bot commented Dec 23, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, dependabot[bot]!). We assume it knows what it's doing!

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 23, 2024
@guibranco guibranco enabled auto-merge (squash) December 23, 2024 14:30
@gstraccini gstraccini bot added the ☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) label Dec 23, 2024
Copy link
Owner

@guibranco guibranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by gstraccini[bot]

@gstraccini gstraccini bot added the 🤖 bot Automated processes or integrations label Dec 23, 2024
@guibranco
Copy link
Owner

@dependabot squash and merge

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 23, 2024

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@AppVeyorBot
Copy link

Build CrispyWaffle 9.1.124 completed (commit 1456a1b07b by @gstraccini[bot])

@guibranco
Copy link
Owner

@dependabot recreate

1 similar comment
@guibranco
Copy link
Owner

@dependabot recreate

Bumps [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet) from 10.3.0.106239 to 10.4.0.108396.
- [Release notes](https://github.com/SonarSource/sonar-dotnet/releases)
- [Commits](SonarSource/sonar-dotnet@10.3.0.106239...10.4.0.108396)

---
updated-dependencies:
- dependency-name: SonarAnalyzer.CSharp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/nuget/SonarAnalyzer.CSharp-10.4.0.108396 branch from bc97dea to 64ca35b Compare December 23, 2024 17:23
Copy link
Contributor

Infisical secrets check: ✅ No secrets leaked!

💻 Scan logs
5:24PM INF scanning for exposed secrets...
5:24PM INF 629 commits scanned.
5:24PM INF scan completed in 785ms
5:24PM INF no leaks found

@AppVeyorBot
Copy link

Build CrispyWaffle 9.1.130 completed (commit 1d6e456d01 by @dependabot[bot])

@guibranco guibranco merged commit c6d9032 into main Dec 23, 2024
29 checks passed
@guibranco guibranco deleted the dependabot/nuget/SonarAnalyzer.CSharp-10.4.0.108396 branch December 23, 2024 17:45
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ff04ac0) 3681 1620 44.01%
Head commit (64ca35b) 3681 (+0) 1620 (+0) 44.01% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#636) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.53%. Comparing base (ff04ac0) to head (64ca35b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   40.45%   40.53%   +0.08%     
==========================================
  Files          83       83              
  Lines        3631     3631              
  Branches      519      519              
==========================================
+ Hits         1469     1472       +3     
+ Misses       2057     2055       -2     
+ Partials      105      104       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) 🤖 bot Automated processes or integrations dependencies Pull requests that update a dependency file .NET Pull requests that update .net code nuget packages size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants