Skip to content

Commit

Permalink
node 18+
Browse files Browse the repository at this point in the history
  • Loading branch information
roblarsen committed Apr 1, 2024
1 parent 6782409 commit 44c3117
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.x, 18.x]
node-version: [18.x, 20.x]
steps:
- name: Get npm cache directory
id: npm-cache
Expand Down
4 changes: 2 additions & 2 deletions docs/about-this-repo.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ Our branch protection rules are as follows:
- We require a pull request (PR) with one approving reviewer to merge code
- In addition to the PR and approving reviewer, we require three status checks
to pass before code can be merged
_ Build with Node 18
_ Build with Node 16 \* LGTM analysis: JavaScript
_ Build with Node 20
_ Build with Node 18 \* LGTM analysis: JavaScript
- We _allow_ force pushes for project admins. While force pushes can create
some head scratching moments for people who have cloned the repo and update
before and after the force push, the ability to clean up the `HEAD` of a
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
"strip-json-comments": "^5.0.1"
},
"engines": {
"node": ">=16",
"npm": ">=8"
"node": ">=18",
"npm": ">=10"
},
"h5bp-configs": {
"directories": {
Expand Down

0 comments on commit 44c3117

Please sign in to comment.