Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list_hdf(): Add return_types parameter #73

Closed
wants to merge 3 commits into from
Closed

Conversation

jan-janssen
Copy link
Member

When the return_types parameter is set to True list_hdf() not only returns the names of the nodes and groups stored in an HDF5 file but also the types of these nodes and groups. This should simplify the implementation of lazy loading approaches.

jan-janssen and others added 3 commits September 11, 2024 09:24
When the return_types parameter is set to True list_hdf() not only returns the names of the nodes and groups stored in an HDF5 file but also the types of these nodes and groups. This should simplify the implementation of lazy loading approaches.
@coveralls
Copy link

coveralls commented Sep 11, 2024

Pull Request Test Coverage Report for Build 10806984753

Details

  • 91 of 104 (87.5%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.0%) to 94.046%

Changes Missing Coverage Covered Lines Changed/Added Lines %
h5io_browser/base.py 47 60 78.33%
Totals Coverage Status
Change from base Build 10785726147: -1.0%
Covered Lines: 695
Relevant Lines: 739

💛 - Coveralls

@jan-janssen
Copy link
Member Author

@pmrv Would this help to implement the lazy loading for the DataContainer in pyiron_base? In particular to address issues like the frequent opening and closing of HDF5 files in the interface for the Sphinx DFT code pyiron/pyiron_atomistics#1574 ?

@jan-janssen jan-janssen marked this pull request as draft September 11, 2024 08:27
@jan-janssen jan-janssen marked this pull request as draft September 11, 2024 08:27
@jan-janssen jan-janssen deleted the hdf5_types branch September 13, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants