Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook configuration to manifest #21

Merged
merged 3 commits into from
Aug 27, 2019
Merged

Webhook configuration to manifest #21

merged 3 commits into from
Aug 27, 2019

Conversation

Villux
Copy link
Contributor

@Villux Villux commented Aug 26, 2019

Add webhook configuration to basemodels. Every events needs to be defined, if webhook events is wanted - no wildcard functionality exists.

I added issue #20 while doing this, but it's not required for this pr.

@Villux Villux requested review from gaieges and e271828- August 26, 2019 08:08
Copy link
Contributor

@gaieges gaieges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, agree on the nested part but lets address that separately

@Villux Villux merged commit 951ccc3 into master Aug 27, 2019
@Villux Villux deleted the feature/webhook branch August 27, 2019 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants