Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add orientation param #62 #63

Merged
merged 5 commits into from
Oct 6, 2024
Merged

feat: add orientation param #62 #63

merged 5 commits into from
Oct 6, 2024

Conversation

CAMOBAP
Copy link
Collaborator

@CAMOBAP CAMOBAP commented Jul 16, 2024

@CAMOBAP CAMOBAP requested a review from e271828- July 16, 2024 16:54
@CAMOBAP CAMOBAP self-assigned this Jul 16, 2024
@CAMOBAP CAMOBAP mentioned this pull request Jul 16, 2024
Closed
3 tasks
e271828-
e271828- reviewed Oct 1, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
e271828-
e271828- reviewed Oct 1, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
e271828-
e271828- reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@e271828- e271828- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing readme update for orientation

@CAMOBAP
Copy link
Collaborator Author

CAMOBAP commented Oct 6, 2024

missing readme update for orientation

Done, ready for review again

@CAMOBAP CAMOBAP requested a review from e271828- October 6, 2024 14:57
e271828-
e271828- approved these changes Oct 6, 2024
View reviewed changes
Copy link
Contributor

@e271828- e271828- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please bump version as well.

@e271828- e271828- merged commit e4df66f into master Oct 6, 2024
5 checks passed
@e271828- e271828- deleted the feature/orientation branch October 6, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e271828- e271828- e271828- approved these changes

Assignees

@CAMOBAP CAMOBAP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CAMOBAP @e271828-