feat: improve UX when user is on a slow network #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `closableLoading` property to allow cancel hCaptcha during loading - `hasBackdrop=false` now affect `backgroundColor` and no backgroun will be shown till hCaptcha is loaded
e271828-
changed the title
e271828-
reviewed
Nov 3, 2024
|
looks good at first glance, need README update + ver bump |
CAMOBAP
force-pushed
the
feature/improve-slow-network-experience
branch
from
1b8c785 to
21742cc
Compare
I did manual tests for all combinations of |
e271828-
approved these changes
Nov 4, 2024
|
README updated |
|
I've been looking forward to this! Do you know when it will be released on npm? One suggestion why not letting the user specify the timeout, while still having the 15 sec as default? |
|
@dev2xl please check 1.8.2 release, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #64
closableLoadingproperty to allow user to tap to cancel hCaptcha during loadinghasBackdrop=falsenow affectsbackgroundColorand no background will be shown till hCaptcha is loaded'error'if hCaptha wasn't load in 15scloses #65