-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type hint check and corrections #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function typing in tests can be optional.
Don't know Nox and Poetry much, but seems nice otherwise.
Don't merge yet, I need to correct the GitHub workflow about code coverage. |
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 309 388 +79
Branches 19 24 +5
=========================================
+ Hits 309 388 +79
Continue to review full report at Codecov.
|
Code coverage check in GA is OK now. We can merge as soon as the code review is done. |
Add type hint checks with mypy and typeguard following best practices of hypermodern_python (see #18).
Code update was needed to correct all errors detected by mypy.