Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonograph-Ansh #724

Merged
merged 8 commits into from
Sep 4, 2024
Merged

Harmonograph-Ansh #724

merged 8 commits into from
Sep 4, 2024

Conversation

ansh3108
Copy link
Member

  • I have read the steps to getting a blot

  • I am submitting art that...

    • is algorithmically generated (will change each time the program is run)
    • is drawable on a blot (fits in the work area & doesn't overlap too much)
    • is original (not copied from somewhere else)
    • doesn't call Math.random() (See the documentation on randomness)
  • Optional, if you used a tutorial or based your art on something else, please include the link here:

  • Optional, if you remixed this from something else, mention it here:

Copy link

github-actions bot commented Jul 20, 2024

art/harmonograph-Ansh/index.js looks like art! preview it in the editor

@ansh3108 ansh3108 changed the title Add files via upload Harmonograph Jul 20, 2024
@ansh3108 ansh3108 changed the title Harmonograph Harmonograph-Ansh Jul 20, 2024
@ansh3108
Copy link
Member Author

You can adjust the values p1, p2, p3, p4, f1, f2..... d1, d2.... To generate art just like a harmonograph does

Copy link
Member

@BrightTheBackpack BrightTheBackpack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really cool! However, It doesn't quite look like the one's I've seen, like this one
image
Do you think you would be able to get it a little closer?

@ansh3108
Copy link
Member Author

I think that's a limitation of blot that it cannot draw this much thin lines, and I don't think the art can be changed further because that's the algorithm for Harmonograph. And for achieving a similar like this, you will most likely to adjust the values

@maxwofford
Copy link
Member

@ansh3108 any update on this? I can't wait to see the next iteration!

@ansh3108
Copy link
Member Author

@maxwofford this is the final version from my side! I don't really believe that it can go a bit further because of the limitations in blot.

Copy link
Member

@maxwofford maxwofford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the latest version working? When I load in the editor it renders like this:
Screenshot 2024-08-02 at 11 29 07

Also, this is a good start but I'm worried the drawings in the snapshot will cut through the page. What if you add some logic to prevent drawing over the same line too many times?

@ansh3108
Copy link
Member Author

ansh3108 commented Aug 2, 2024

oh, you have to adjust the values as i mentioned earlier

@ansh3108
Copy link
Member Author

ansh3108 commented Aug 2, 2024

image

It kinda looks something like you mentioned

@ansh3108
Copy link
Member Author

image

This's how it looks like when drawn with a blot!

Copy link
Member

@maxwofford maxwofford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-08-12 at 13 29 29 What am I doing wrong here? I keep trying to run it and I just get a straight line

@maxwofford
Copy link
Member

Oh, just saw your comment. Please update your code so it generates that without adjusting the values! if you have some adjustable variables you can also hook them up with the provided random function

@ansh3108
Copy link
Member Author

Sure!

@ansh3108
Copy link
Member Author

@maxwofford Done with the changes!

Copy link
Member

@qcoral qcoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This art piece introduced me to something I've never seen before, which is pretty cool. I think it's great, but I'd love if you could add a small section in your code (maybe at the top?) just explaining what a harmonograph is and more about the whole piece in general (like why you made it etc). I'll swing back around soon!

@ansh3108
Copy link
Member Author

alright! on it

Copy link

vercel bot commented Aug 25, 2024

@ansh3108 is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@ansh3108
Copy link
Member Author

Done! @qcoral

Copy link
Member

@qcoral qcoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better, but I still think you can explain more. Pure mathematic implementations are not very interesting by itself, but they have tons of value if you're able to use the visual drawing from Blot to help you explain the process. Maybe explaining what the functions/variables generally do?

@ansh3108
Copy link
Member Author

Added!

Copy link
Member

@qcoral qcoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on the new changes! I like the descriptions, and it's definitely much more informative. Congrats, you can order a Blot here

@qcoral qcoral merged commit e8bbf81 into hackclub:main Sep 4, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants