-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Greendale-Eamonn #850
Greendale-Eamonn #850
Conversation
@JimmmithyOrSomething is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
I dont know how to get Vercel to deploy. |
Dw about the vercel stuff |
Sorry what do you mean by that? |
@BrightTheBackpack sorry I forgot to tag you in my message. What do you mean by "Dw about the vercel stuff"? -thank you |
dw = don't worry, don't worry about the vercel stuff, it doesn't really matter |
@BrightTheBackpack Ok, thank you but dont I need vercel to run inorder for someone to get assinged to my pull request? Because last time that I did one of these it took a few days to get vercel to run and no one was added untill it was deployed. thanks again. |
it would help if you changed your js file name to index.js though i think |
|
@BrightTheBackpack Ok, thanks I did that. Is there anything else I need to do to get approved?. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the intentional design with this scene, but most of it is hard-coded. Would there be a way for you to generate it more algorithmically? I'll swing back around later
@qcoral Thank you so much for the suggestion. I went back and added a new feature where the flag will flap in the wind so it can be a diffrent shape every time it runs. |
@qcoral Hello I was just wondering if I had to add anthing else after I put in the changing flag to get it approved? No rush to respond I just want to know if I need to do anything else. Thanks |
@qcoral Hi, I was just wondering if I have to do something else to get my project approved as it has been a while and I have not gotten any new information. Thanks. |
This could use more work! Currently only the flag is random, I would like to see the buildings in different spots, the graphic on the flag different! Please create a new PR once you have updated your art, keep working at it! I am doing this due to a new management system for PRs. |
Write a short description about your art piece, such as what your artwork represents and your experience drawing it!
This art is of the logo of Greendale collage from the amazing TV show Community. The drawing has a flag with the logo as well as some buildings in the background. inside the code editor you can change some settings: one lets you unlock the logo allowing the arrows to spin freely and they will be diffrent every time. Another thing you can change is that you can remove the background if you want more of a simple image. You can also change the flagMove option to let the flag flap in the wind making a diffrent shape every time you run it. I spent a long time on this as it was the first time I have drawn anything in java script but I really liked doing it and I think it came out really nice.
Math.random()
(See the documentation on randomness)If you used based your art on something else, used a tutorial, or remixed it from something else, please link it here:
Lastly, link a picture of your art piece here: