Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cat Catch #37

Merged
merged 5 commits into from
Feb 5, 2025
Merged

Add Cat Catch #37

merged 5 commits into from
Feb 5, 2025

Conversation

artifishvr
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jan 28, 2025

@artifishvr is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@acornitum acornitum added the needs review needs acon to check over it , ,,,, label Jan 29, 2025
@acornitum
Copy link
Contributor

This is a nice game! I especially like the art of the character you have there - you were able to cram so much detail in a small space. The burger sprite is cool too!

However, there are some things I'd like to see before I merge this PR:

  • Currently, when I play this game, after the first 3 burgers, nothing else falls after? I took a peek at your code and it looks like you intend for more to fall - it's not showing up on my screen tho, do you know why / could you fix this :'D
  • Add a start screen! I think this is important for rhythm games as it catches me off guard when it jumps straight into gameplay without a warning
  • What if you animated the cat? For example, make its ears twitch! Another idea is to have more and more hamburgers pile up on the plate, depending on what the player's score is
  • Speaking of scores, maybe add a score so that the player knows how well they're doing? This seems pretty standard for rhythm games
  • Maybe add a bit more onto the background? For example, it shouldn't be too hard to make a rough gradient on the spiral galaxies you got there. Something like this would be pretty cool (art tip: colorpick straight from the image!)

This is a really good start! That music choice is great too. Thanks for submitting + I can't wait to see where this is at after you've made those changes!

Note: don't open a new PR, just commit changes to this current thread + send a comment when changes have been made!

@acornitum acornitum removed the needs review needs acon to check over it , ,,,, label Jan 30, 2025
@artifishvr
Copy link
Contributor Author

artifishvr commented Jan 31, 2025

Tysm! dw, i'll work on the rest of those things too when I have time within the next day or so c:

checklist for mostly my own reference:

  • Fix burger spawn bug
  • Start screen
  • Score
  • Improve bg
  • Burger on plate after catch, remove when miss
  • Cat animations?

@artifishvr
Copy link
Contributor Author

@acornitum hi! i think i've done those changes and i'm ready to be re-reviewed!

@acornitum
Copy link
Contributor

Thank you!! This is so much better - I love how you implemented the burger moving on the plate, and the background looks so much better.

I'm going to merge this! Fill out the form here: https://forms.hackclub.com/t/isDdJtrnrvus

Thank you so much!

@acornitum acornitum merged commit 8ae651d into hackclub:main Feb 5, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants