Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up Tap To Pay by over 30 seconds! #136

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Speed up Tap To Pay by over 30 seconds! #136

merged 1 commit into from
Jan 15, 2025
+21 −9

Conversation

thedev132
Copy link
Collaborator

Summary of the problem

too slow

Describe your changes

SPEED

Checklist

  • Descriptive PR title (Does the title explain the changes in a concise manner?)
  • Tag related issues so they auto-close on merge
  • Easily digestible commits (Are the commits small and easy to understand?) video
  • CI passes (Do the GitHub checks pass?)
  • Tested by submitter before requesting review (Does it work in development iOS/android? )

@thedev132 thedev132 requested a review from a team as a code owner January 15, 2025 05:38
@Luke-Oldenburg Luke-Oldenburg merged commit d15a7f8 into hackclub:tap-to-pay Jan 15, 2025
@Luke-Oldenburg
Copy link
Collaborator

@thedev132 was it intentional to merge into hackclub:tap-to-pay instead of hackclub:main?

@thedev132
Copy link
Collaborator Author

Oh shit no should be into main oops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yednapg yednapg yednapg approved these changes

@Luke-Oldenburg Luke-Oldenburg Luke-Oldenburg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thedev132 @Luke-Oldenburg @yednapg