fix: no more dataurls & localhost links #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeonGamerBot-QK
requested review from
malted,
maxwofford and
polytroper
as code owners
|
@NeonGamerBot-QK is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
NeonGamerBot-QK
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Lol, love this. I'll merge it after testing it out! |
|
Wait up! |
malted
reviewed
Dec 2, 2024
malted
reviewed
Dec 2, 2024
Comment on lines
+25
to
+31
| value: JSON.stringify( | ||
| ships.map((s) => { | ||
| if (s.screenshotUrl.startsWith('data:')) | ||
| s.screenshotUrl = `replace_me_with_a_non_dataencoded_url_plz` | ||
| return s | ||
| }), | ||
| ), |
There was a problem hiding this comment.
Is this to fix data that is currently incorrect in the wild?
There was a problem hiding this comment.
yes! currently it soft locks users (aka vercel 500) which means they cant ship projects. ofc i can remove this and you guys will have to unlock them manually ;-;
There was a problem hiding this comment.
Ok amazing - tysm for this fix!
|
@malted I'll leave this for you to merge then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #899 #901
Closes #899
Closes #901
this also makes it so only
http(s)urls work