Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't proxy if not modified #103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't proxy if not modified #103

wants to merge 1 commit into from

Conversation

dispherical
Copy link
Member

No description provided.

Copy link
Member

@hello-smile6 hello-smile6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that everyone uses caddy would be bad imo, also, if they've created a domain, they clearly aren't inactive. Why not store a value in the database once a user shows signs of existing (e.g. having more than just their user domain configured or reconfiguring their user domain)? It doesn't seem like any actual memory savings would occur from this, since we'd still be running hundreds of caddy processes.

@dispherical
Copy link
Member Author

dispherical commented Oct 30, 2024

Assuming that everyone uses caddy would be bad imo, also, if they've created a domain, they clearly aren't inactive. Why not store a value in the database once a user shows signs of existing (e.g. having more than just their user domain configured or reconfiguring their user domain)? It doesn't seem like any actual memory savings would occur from this, since we'd still be running hundreds of caddy processes.

This was your suggestion...

Can we make something that runs whenever a user's Caddyfile is first modified by a user and make the global caddy not actually proxy to the user's caddy until the first modification happens to decrease memory usage and avoid wasting RAM on users who haven't done anything yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants