Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Project Profile: Civic Tech Jobs Add Roja Pinnamraju #7832

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Update Project Profile: Civic Tech Jobs Add Roja Pinnamraju #7832

wants to merge 1 commit into from

Conversation

oiseeurmt
Copy link
Member

@oiseeurmt oiseeurmt commented Jan 15, 2025 •
edited
Loading

Fixes #7742

What changes did you make?

  • added Roja Pinnamraju's profile to Civic Tech Jobs

Why did you make the changes (we will use this info to test)?

  • We need to keep project information up to date so that visitors to the website can find accurate information.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied before
Visuals after changes are applied after

@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b oiseeurmt-update-project-profile-7742 gh-pages
git pull https://github.com/oiseeurmt/website.git update-project-profile-7742

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jan 15, 2025
@mugdhchauhan mugdhchauhan self-requested a review January 16, 2025 17:42
@mugdhchauhan
Copy link
Member

Review ETA: 16 Jan 2025 @ 8 PM (GMT)
Availability: Daily @ 6 PM - 8 PM (GMT)

mugdhchauhan
mugdhchauhan requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@mugdhchauhan mugdhchauhan left a comment •
edited by oiseeurmt
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @oiseeurmt, thanks for working on this!

Kudos

  • The pull request is made with the correct branch.
  • The pull request post contains a linked issue, CodeQL alerts have been checked, and the screenshots section is complete.
  • The changes to the _projects/civic-tech-jobs.md file are accurate.
  • I can see the changes in my local environment.
  • You have claimed the issue well.

Suggested changes

Please make the following changes to the PR post:

  • Provide more detail as to why you have made these changes. You can use the "Overview" section of the originating issue for this.
  • Remove unused bullet points.
  • You could rename the title to "Update Project Profile: Civic Tech Jobs Add Roja Pinnamraju".

For next time:

  • Please use a more descriptive branch name for your relevant task such as civic-tech-jobs-add-Roja-Pinnamraju-7742.
  • Try to include date and time when providing progress update or availability and ETA (like shown below).
ETA: 6 PM 3/4/22
Availability: 5-8 PM Monday

After making these changes, re-request a review from me. Feel free to reach out if you need help with anything.

@mugdhchauhan mugdhchauhan mentioned this pull request Jan 16, 2025
Open
@oiseeurmt oiseeurmt changed the title Update Profile in Civic Tech Jobs Page Update Project Profile: Civic Tech Jobs Add Roja Pinnamraju Jan 18, 2025
@oiseeurmt
Copy link
Member Author

Hey @oiseeurmt, thanks for working on this!

Kudos

  • The pull request is made with the correct branch.
  • The pull request post contains a linked issue, CodeQL alerts have been checked, and the screenshots section is complete.
  • The changes to the _projects/civic-tech-jobs.md file are accurate.
  • I can see the changes in my local environment.
  • You have claimed the issue well.

Suggested changes

Please make the following changes to the PR post:

  • Provide more detail as to why you have made these changes. You can use the "Overview" section of the originating issue for this.
  • Remove unused bullet points.
  • You could rename the title to "Update Project Profile: Civic Tech Jobs Add Roja Pinnamraju".

For next time:

  • Please use a more descriptive branch name for your relevant task such as civic-tech-jobs-add-Roja-Pinnamraju-7742.
  • Try to include date and time when providing progress update or availability and ETA (like shown below).
ETA: 6 PM 3/4/22
Availability: 5-8 PM Monday

After making these changes, re-request a review from me. Feel free to reach out if you need help with anything.

Thanks for the feedback! I made the changes and will note your suggestions and re-requested the PR

@mugdhchauhan
Copy link
Member

Review ETA: 19 Jan 2025 @ 6 PM (GMT)
Availability: Daily @ 6 PM - 8 PM (GMT)

mugdhchauhan
mugdhchauhan approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@mugdhchauhan mugdhchauhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @oiseeurmt, thanks for making the changes. I have approved this PR now. 👍

@Cloid Cloid self-requested a review January 20, 2025 03:35
@Cloid
Copy link
Member

Cloid commented Jan 20, 2025

Review ETA: 5 PM 1/20/25
Availability: 5-8 PM Weekdays

@Cloid
Copy link
Member

Cloid commented Jan 20, 2025

This looks great!

I tested it on Windows computer on both Chrome and Firefox browsers. I clicked on the links and made sure they were being redirected to the correct user. The description, explanation of the case, and the code are all great too.

Great job, approving this on my end.

Cloid
Cloid approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@Cloid Cloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved see comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mugdhchauhan mugdhchauhan mugdhchauhan approved these changes

@Cloid Cloid Cloid approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
P: HfLA Website: Project Board
Status: PRs ✅ waiting for merge team
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Civic Tech Jobs Add Roja Pinnamraju
3 participants
@oiseeurmt @mugdhchauhan @Cloid