-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove additional check for .can_download #4370
Conversation
📝 WalkthroughWalkthroughThe pull request modifies the Changes
Assessment against linked issues
The change appears to directly address the issue reported in #4183, where beta-targeted releases were preventing installation of older versions. By removing the version compatibility check, the code now allows installation of repositories across different Home Assistant versions, which was the core problem described in the issue. However, this solution comes with a potential drawback of removing an important safeguard that previously prevented installing incompatible integrations. While it resolves the immediate installation blocker, it may introduce risks of installing integrations that are not fully compatible with the user's Home Assistant version. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Closes #4183