Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修正 Nginx Proxy Manager 关于容器内网络的描述,以及相关改动 #473

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

qksuki
Copy link

@qksuki qksuki commented Nov 22, 2024

相关 Discussion

我修改了容器内网络的一些描述,包括 docker compose 文件的修改,文字的描述,使用别名替换实际 IP,修改了图片文件中的Forward Hostname/IP 等,详情可以查看 commit。

Copy link

f2c-ci-robot bot commented Nov 22, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
halo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 3:02am

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 22, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen November 22, 2024 16:01
Copy link

f2c-ci-robot bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign guqing for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -54,6 +54,12 @@ services:
volumes:
- ./data:/data # 点号表示当前文件夹,冒号左边的意思是在当前文件夹下创建一个 data 目录,用于存放数据,如果不存在的话,会自动创建
- ./letsencrypt:/etc/letsencrypt # 点号表示当前文件夹,冒号左边的意思是在当前文件夹下创建一个 letsencrypt 目录,用于存放证书,如果不存在的话,会自动创建
networks:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我建议是 Halo 去加入 Nginx Proxy Manager 的 Network,以 Nginx Proxy Manager 的 Network 为主,类似于 Traefik 的文档:https://docs.halo.run/getting-started/install/other/traefik

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我参考了 Traefik 的样例,又双修改了文档,让 halo 和 NPM 处于同一网络(nginx-proxy-manager)中。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants