-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove multiple Xcode targets #97
base: main
Are you sure you want to change the base?
Remove multiple Xcode targets #97
Conversation
Updated the Xcode config file by reducing the number of targets (one per platform) as the same can be achived by adding multiple platforms to TARGETED_DEVICE_FAMILY and SUPPORTED_PLATFORMS for a single target. This have been done using the XcodeTargets config file. Additionally the Cartfile and Podspec have been updated to reflect these changes and to support xros (visionOS).
Updated the workflow to reflect the changes in the project file. Additionally added build support for visionOS.
So many platforms, so few targets… wow. I think we can get rid of the old libochamcrest scheme, so I'm doing that. |
Now if we can resolve the |
Thanks for fixing the I've updated the |
Updated almost all xcodebuild archive calls to include the destination argument. Additionally change the arguments for the xcodebuild -create-xcframework to use the archive argument in a combination with the framework argument (please see https://developer.apple.com/documentation/xcode/creating-a-multi-platform-binary-framework-bundle).
Wow, you fixed the script! |
I just tried to call the
and I assume that is due to you can't run the visionOS Simulator on an Intel Mac. Should we consider updating the |
Honestly, I don't think anyone will run that script from an Intel Mac. A cheap workaround might be to add a comment saying so… what do you think? |
@jonreid, For now I think your suggestion would do it but later we could explore if using the destinations from the |
Updated the Xcode project to contain only one library target and a test target. The library target has been updated to support multiple platforms (including visionOS) and multiple TARGETED_DEVICE_FAMILY. All configuration related to the target platforms have been extracted into
XcodeTargets.xcconfig
including the deployment targets. Additionally theCartfile
,Podspec
andmakeXCFramework.sh
have been updated to reflect these changes.There may be one outstanding issue as
makeXCFramework.sh
fails when it reaches the last command in the script (xcodebuild -create-xcframework
) where it is trying to create a XCFramework. It looks like it is related to macOS and Catalyst: