Refactor package cache + more concurrency improvements #1765
+146
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dotasek
commented
Oct 4, 2024
•
dotasek
commented
- Make deleting packages atomic (first rename to temp directory, then delete)
- Apply indexing and renaming code operations to temporary package install before rename
- Track last update for CI build server. Should refresh only when 24 hours has elapsed (need to test this. Do not merge until this has a test).
Make deletes atomic Apply indexing and renaming code operations to temporary package install before rename Track last update for CI build server (refresh every 24 hours)
…cache-concurrency-2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1765 +/- ##
=========================================
Coverage 12.84% 12.85%
- Complexity 33743 33750 +7
=========================================
Files 2240 2240
Lines 684644 684654 +10
Branches 202149 202153 +4
=========================================
+ Hits 87972 87983 +11
- Misses 565419 565420 +1
+ Partials 31253 31251 -2 ☔ View full report in Codecov by Sentry. |
|
I don't remember where this ended up? |
|
I do not recall either; I'll have to review where this was before we started on the ManagedWebAccess refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.