Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailcheck: fix problem when calling check_cmd with a variable in profile #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

xmailla
Copy link

@xmailla xmailla commented Dec 29, 2024

See issue #1 on original project.

My $MBLAZE is set to /Users/x/.config/mail

In my mblaze profile, I customized MailCheckCommand to be: MailCheckCommand: fdm -f $MBLAZE/fdmrc -q fetch

My small fix permits this otherwise, mailcheck aborts.

See issue haqistan#1 on original project.

My $MBLAZE is set to /Users/x/.config/mail

In my mblaze profile, I customized MailCheckCommand to be:
MailCheckCommand: fdm -f $MBLAZE/fdmrc -q fetch

My small fix permits this otherwise, mailcheck aborts.
Fixes issue haqistan#1 by adding a new function to query option in the user
profile.

Thi version is both more robust and reliable when a user uses variables
(like $HOME, $BLAZE or anything else) in his profile to specify path to
commands or files.

With this patch, user can now have this:
MailCheckIndexCommand: mairix -f $MBLAZE/mairixrc

It will be automatically transformed as: mairix -f
/whatever/path/to/file/mairixrc at runtime.

All the options are now using getmblazeopt to be filled.

This commit is replacing 517694b
Install new function getmblazeopt() to query $BLAZE/profile
@haqistan
Copy link
Owner

haqistan commented Jan 4, 2025

hi! glad to meet you. Please work off of the trunk branch, I don't use the term "master" if possible. i am looking at your patch now

@xmailla
Copy link
Author

xmailla commented Jan 4, 2025

Hello,

we discussed each other over mail (I am Xavier). I am not used to git things so excuse me if I am doing things badly. At first, I wished to only push a fix for mailcheck but doing a PR did enclosed all the stuff I am currently modifying. I do not know how to stop that.

@haqistan
Copy link
Owner

haqistan commented Jan 4, 2025

Re github it's no worries, I also find it confusing onhere.
I have reviewed your changes and understand your issue. I did not have gettext installed nor
did I know that envsubst(1) existed. Now that I do I will make some changes to respect $ENVARS
in settings in .mblaze/profile across the board. Give me a day or two.

Thanks for the energy you put into this.

@haqistan
Copy link
Owner

Hi, Xavier, I finally have a comprehensive fix for the envsubst issue in mblaze-tools, will be checking it in on the trunk branch directly

@haqistan haqistan self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants