-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mailcheck: fix problem when calling check_cmd with a variable in profile #2
base: master
Are you sure you want to change the base?
Conversation
See issue haqistan#1 on original project. My $MBLAZE is set to /Users/x/.config/mail In my mblaze profile, I customized MailCheckCommand to be: MailCheckCommand: fdm -f $MBLAZE/fdmrc -q fetch My small fix permits this otherwise, mailcheck aborts.
… in profile" This reverts commit 517694b.
Fixes issue haqistan#1 by adding a new function to query option in the user profile. Thi version is both more robust and reliable when a user uses variables (like $HOME, $BLAZE or anything else) in his profile to specify path to commands or files. With this patch, user can now have this: MailCheckIndexCommand: mairix -f $MBLAZE/mairixrc It will be automatically transformed as: mairix -f /whatever/path/to/file/mairixrc at runtime. All the options are now using getmblazeopt to be filled. This commit is replacing 517694b
Install new function getmblazeopt() to query $BLAZE/profile
hi! glad to meet you. Please work off of the trunk branch, I don't use the term "master" if possible. i am looking at your patch now |
Hello, we discussed each other over mail (I am Xavier). I am not used to git things so excuse me if I am doing things badly. At first, I wished to only push a fix for mailcheck but doing a PR did enclosed all the stuff I am currently modifying. I do not know how to stop that. |
Re github it's no worries, I also find it confusing onhere. Thanks for the energy you put into this. |
Hi, Xavier, I finally have a comprehensive fix for the envsubst issue in mblaze-tools, will be checking it in on the trunk branch directly |
See issue #1 on original project.
My $MBLAZE is set to /Users/x/.config/mail
In my mblaze profile, I customized MailCheckCommand to be: MailCheckCommand: fdm -f $MBLAZE/fdmrc -q fetch
My small fix permits this otherwise, mailcheck aborts.