New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add WalletConnect integration for Ledger devices #720

Open

polymorpher wants to merge 17 commits into harmony-one:master from polymorpher:devin/1738830151-fix-ledger-signing

Contributor

polymorpher commented Feb 6, 2025

Fixes #719

Problem:

Sign-in with Ledger is broken after updating to new Ethereum-based Ledger app
Current direct Ledger integration is incompatible with new app

Solution:

Implement WalletConnect integration for Ledger devices
Users can now connect through Ledger Live using WalletConnect
Follow MetaMask integration pattern for contract interactions
Use modern libraries (@wagmi/vue, viem, @reown/appkit-cli)

Testing:

Connect Ledger through Ledger Live using WalletConnect
Verify address derivation
Test staking operations

Note: This implementation follows the new approach suggested in #719, using WalletConnect instead of modifying the existing Ledger integration.

Link to Devin run: https://app.devin.ai/sessions/9e403c268ac34438a5e04b2de9cc557e
Requested by: Aaron

devin-ai-integration bot and others added 2 commits

February 6, 2025 11:53


          feat: add WalletConnect integration for Ledger devices

9114e0e

- Add WalletConnect integration using @reown/appkit
- Replace direct Ledger integration with WalletConnect
- Update session management to support WalletConnect
- Add Harmony Mainnet chain configuration

Link to Devin run: https://app.devin.ai/sessions/9e403c268ac34438a5e04b2de9cc557e
Requested by: Aaron

Co-Authored-By: Aaron Li <[email protected]>


          Merge branch 'master-polymorpher' into devin/1738830151-fix-ledger-si…

1313fb3

…gning

# Conflicts:
#	frontend/yarn.lock

polymorpher commented

View reviewed changes

frontend/src/scripts/walletconnect-utils/index.js Outdated

+                const { gasEstimate } = fee
+                const { chain_id, rpc_url } = networkConfig
+                const harmony = new Harmony(rpc_url, {

Contributor Author

polymorpher Feb 6, 2025

This is incorrect. Harmony class is undefined. Please do not simply copy from old implementations. Instead, properly invoke correct contract calling methods from wagmi

polymorpher commented

View reviewed changes

frontend/src/scripts/walletconnect-utils/index.js Outdated

+                switch (transactionData.type) {
+                  case "MsgSend":
+                    return harmony.transactions.signTransaction({

Contributor Author

polymorpher Feb 6, 2025

Similarly, this is incorrect because the instance harmony would not exist and would not have the field transactions

polymorpher commented

View reviewed changes

frontend/src/scripts/walletconnect-utils/index.js Outdated

+                    })
+                  case "MsgDelegate":
+                    return harmony.stakings.delegate({

Contributor Author

polymorpher Feb 6, 2025

same as above

polymorpher commented

View reviewed changes

frontend/src/scripts/walletconnect-utils/index.js Outdated

+                    })
+                  case "MsgUndelegate":
+                    return harmony.stakings.undelegate({

Contributor Author

polymorpher Feb 6, 2025

same as above

polymorpher commented

View reviewed changes

frontend/src/scripts/walletconnect-utils/index.js Outdated

+                    })
+                  case "MsgWithdrawDelegationReward":
+                    return harmony.stakings.collectRewards({

Contributor Author

polymorpher Feb 6, 2025

same as above

devin-ai-integration bot and others added 15 commits

February 6, 2025 12:21


          fix: update WalletConnect integration to use wagmi contract methods

4e02ae5

- Replace Harmony class usage with wagmi's writeContract
- Add proper error handling in WalletConnect component
- Use correct contract ABI and address for staking operations
- Implement gas estimation using wagmi methods

Co-Authored-By: Aaron Li <[email protected]>


          chore: update babel config to support optional chaining

085b220

Co-Authored-By: Aaron Li <[email protected]>


          Merge branch 'master' into devin/1738830151-fix-ledger-signing

5e3867e

# Conflicts:
#	frontend/src/components/common/TmSessionExisting.vue
#	frontend/yarn.lock


          Reapply "fix: update chromedriver and add M1/M2 Mac support (harmony-…

258e27e

…one#718)"

This reverts commit 6a3e2ee.

# Conflicts:
#	frontend/yarn.lock


          chore: update @wagmi/core and viem dependencies

e624b4e

Co-Authored-By: Aaron Li <[email protected]>


          chore: remove @babel/polyfill import in favor of babel useBuiltIns usage

35fbbac

Co-Authored-By: Aaron Li <[email protected]>


          feat: add wagmi configuration for Harmony Mainnet

b36cc73

Co-Authored-By: Aaron Li <[email protected]>


          feat: add contract interaction utilities using wagmi

9f19746

Co-Authored-By: Aaron Li <[email protected]>


          fix: use numeric decimals instead of string unit for parseUnits

b6328e0

Co-Authored-By: Aaron Li <[email protected]>


          fix: add TypeScript types for contract interaction utilities

cbd48e1

Co-Authored-By: Aaron Li <[email protected]>


          fix: handle undefined amount in contract interactions

128db1e

Co-Authored-By: Aaron Li <[email protected]>


          fix: restore parseUnits usage for amount conversion

f85cd48

Co-Authored-By: Aaron Li <[email protected]>


          chore: resolve merge conflicts in yarn.lock

975a4b2

Co-Authored-By: Aaron Li <[email protected]>


          remove some dependencies

4653e59


          add back package

5c61134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet