Add interstitial to search nav link. #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccacremona
requested review from
bensteinberg
and removed request for
a team
bensteinberg
requested changes
Apr 10, 2024
Co-authored-by: Ben Steinberg <[email protected]>
bensteinberg
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ENG-750.
Currently, we link straight to the advanced search page at CourtListener in the main navigation and in the footer.
This PR switches the header link to toggle an interstitial instead, explaining what we are up to. Per discussion with Greg: since there is a lot of copy, the interstitial waits for the user to click through, rather than auto-redirecting after a few seconds. (There are usability plusses and minuses to both styles, but I think this is the correct choice.)
I didn't do anything fancy with the styles. TBD if the link wants to look more prominent: if it does, I would love for the particulars of the design to be dictated rather than improvised :-)
Never visited, triggered by mouse
Already visited once, triggered by keyboard
Mobile
Because
dialogis magic, all the keyboard stuff JUST WORKS: focus is trapped inside the modal, focus sets to the link on toggle, escape dismisses and focus returns to the nav link, et voila.I decided not to include it redundantly in the page footer; seem unnecessary.