Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Snippet Removal Part 1— TSV generation to download_storages #1932

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

ChefAndy
Copy link
Contributor

This part just moves the TSV snippets to regular files. Part 2 with the caching coming up.

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #1932 (0c81cdb) into develop (879c13c) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1932      +/-   ##
===========================================
+ Coverage    59.60%   59.62%   +0.01%     
===========================================
  Files          102      103       +1     
  Lines        10251    10263      +12     
===========================================
+ Hits          6110     6119       +9     
- Misses        4141     4144       +3     
Impacted Files Coverage Δ
capstone/capstone/scripts/update_snippets.py 86.84% <0.00%> (-4.07%) ⬇️
capstone/capstone/fabfile.py 35.26% <0.00%> (-0.01%) ⬇️
capstone/capstone/scripts/update_download_tsv.py 93.22% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f00bb9...0c81cdb. Read the comment docs.

Copy link
Contributor

@jcushman jcushman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start! I think rather than storing these in the base downloads directory, we should store them with each bulk export. You could update scripts.export.init_export to call scripts.update_download_tsv.update_all at the end, with a path of output_path / 'statistics'. And then the about.md links can go to {% url "download-files" "bulk_exports/latest/statistics/..." %}

@jcushman jcushman marked this pull request as draft August 3, 2021 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants