Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: start converting user management views' tests to pytest format #3621

Draft
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

rebeccacremona
Copy link
Contributor

@rebeccacremona rebeccacremona commented Oct 15, 2024

This work was started during the Q3 housekeeping cycle, but was not finished.

Still to do:

  • test_org_export_user_list
  • test_sponsored_user_export_user_list
  • test_create_and_delete_user
  • All the tests in "### ADDING NEW USERS TO ORGANIZATIONS ###"
  • All the tests in "### ADDING EXISTING USERS TO ORGANIZATIONS ###"
  • All the tests in "### VOLUNTARILY LEAVING ORGANIZATIONS ###"
  • All the tests in "### REMOVING USERS FROM ORGANIZATIONS ###"
  • All the tests in "### ADDING NEW USERS TO REGISTRARS AS SPONSORED USERS ###"
  • All the tests in "### ADDING EXISTING USERS TO REGISTRARS AS SPONSORED USERS ###"
  • All the tests in "### TOGGLING THE STATUS OF SPONSORSHIPS ###"
  • All the tests in "### ADDING NEW USERS TO REGISTRARS AS REGISTRAR USERS) ###"
  • All the tests in "### ADDING EXISTING USERS TO REGISTRARS ###"
  • All the tests in "### REMOVING REGISTRAR USERS FROM REGISTRARS ###"
  • All the tests in "### ADDING NEW USERS AS ADMINS ###"
  • All the tests in "### ADDING EXISTING USERS AS ADMINS ###"
  • All the tests in "### REMOVING USERS AS ADMINS ###"

Not in scope:

  • Any tests of filters. those are going to be a pain to convert, as long as JSON fixtures are still being installed. (edit: I added a helper to delete interfering JSON fixtures... but I still think those should all be done at once... may be there is a much more efficient way to test)
  • "### SIGNUP" (should be their own file)
  • "### PASSWORD RESETS ###" (should be elsewhere)

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.19%. Comparing base (ffa57fa) to head (45f914d).
Report is 35 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3621      +/-   ##
===========================================
+ Coverage    69.67%   70.19%   +0.51%     
===========================================
  Files           54       54              
  Lines         7661     7801     +140     
===========================================
+ Hits          5338     5476     +138     
- Misses        2323     2325       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant