Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal upgrade to Postgres 16 #3680

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Minimal upgrade to Postgres 16 #3680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9165b7e
Minimal upgrade to Postgres 16
bensteinberg Jan 2, 2025
3758ca7
Remove old volume; additionally update payments db
bensteinberg Jan 9, 2025
92dd748
Overdue update of payments image
bensteinberg Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docker-compose.override.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,16 +82,16 @@ services:
# Perma Payments
#
pp_db:
image: registry.lil.tools/library/postgres:12.8
image: registry.lil.tools/library/postgres:16.6
environment:
- POSTGRES_PASSWORD=example
volumes:
- pp_db_data:/var/lib/postgresql/data:delegated
- pp_db_data_16:/var/lib/postgresql/data:delegated
networks:
- perma_payments

perma-payments:
image: registry.lil.tools/harvardlil/perma-payments:19-feb5e21507118e85975cc35a5e15c5c4
image: registry.lil.tools/harvardlil/perma-payments:20-cd472eae28bb3affe3b6da1880ff17a2
# hack: sleep to give the database time to start up
command: >
sh -c "sleep 5 && ./manage.py migrate && invoke run"
Expand Down
8 changes: 4 additions & 4 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ services:
volumes:
- redis_data:/data:delegated
db:
image: registry.lil.tools/library/postgres:12.11
image: registry.lil.tools/library/postgres:16.6
environment:
POSTGRES_PASSWORD: password
POSTGRES_DB: perma
POSTGRES_USER: perma
volumes:
- postgres_data:/var/lib/postgresql/data:delegated
- postgres_data_16:/var/lib/postgresql/data:delegated
networks:
- default
- superset
Expand Down Expand Up @@ -140,9 +140,9 @@ services:

volumes:
node_modules:
postgres_data:
postgres_data_16:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of updating the volume's name! Less confusing for folks pulling down the changes.

What's the thought re: keeping both postgres_data and postgres_data_16 defined here?

Copy link
Contributor Author

@bensteinberg bensteinberg Jan 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a vague notion about devs possibly wanting to keep and use the old volume, as in

some remark about keeping or deleting old volumes

but I think I'll remove it from the docker compose file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Yeah. That's what I figured. I always have a few extras around, for instance, one or two prod-like dumps put together this way, so I'm used to having volumes available that aren't listed in the compose file. 🤷‍♀️. No opinion on whether that's good or bad practice.

redis_data:
pp_db_data:
pp_db_data_16:
scoop_redis_data:
scoop_postgres_data:
scoop_access_key:
Expand Down