Provide more detailed error message on transaction failure #10208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10208 +/- ##
============================================
- Coverage 92.23% 92.21% -0.02%
- Complexity 7942 7943 +1
============================================
Files 971 971
Lines 33231 33248 +17
Branches 4180 4180
============================================
+ Hits 30649 30661 +12
- Misses 1598 1603 +5
Partials 984 984 ☔ View full report in Codecov by Sentry. |
…rds for the executed transaction Signed-off-by: sdimitrov9 <[email protected]>
sdimitrov9
force-pushed
the
improve-handleFailedResult-to-provide-info-about-all-transaction-records-for-the-executed-transaction
branch
from
facdead to
39f5ad5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Improve handleFailedResult method to provide info about all transaction records for the executed transaction, specifically to return more detailed message on failure, like "...message=CONTRACT_REVERT_EXECUTED -> TREASURY_MUST_OWN_BURNED_NFT,..." instead of just "..message=CONTRACT_REVERT_EXECUTED..."
Checklist