Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept Transaction.body and normalize transactions #17448

Open
15 tasks
netopyr opened this issue Jan 20, 2025 · 0 comments · May be fixed by #17449
Open
15 tasks

Accept Transaction.body and normalize transactions #17448

netopyr opened this issue Jan 20, 2025 · 0 comments · May be fixed by #17449
Assignees

Comments

@netopyr
Copy link
Contributor

netopyr commented Jan 20, 2025

Background

The TransactionChecker has to be updated to accept the new normalized format for Transaction. If a transaction is received that uses bodyBytes or signedTransactionBytes, we must create a normalized version of the transaction and use it in the remaining code.

Acceptance Criteria

  1. The consensus node can handle transactions that use either body + sigMap, bodyBytes + sigMap, or signedTransactionBytes.
  2. If the consensus node receives a transaction that uses bodyBytes or signedTransactionBytes, it will normalize the transaction and write the normalized transaction into the record stream/block stream.

Dependencies

Definition of Ready (DoR) Checklist

  • Clear acceptance criteria
  • Clear and detailed description
  • Dependencies identified
  • Links to documentation
  • Should be completable in 2-3 Days
  • Initial draft of Low-level design document
  • At least high level test plan
  • Groomed/Estimated

Definition of Done (DoD) Checklist

  • Acceptance Criteria complete
  • No Codacy issues greater than minor (in new code)
  • JavaDocs updated/created
  • Code commented
  • Unit tests created/updated
  • 80% test code coverage (in new code)
  • Happy Path and major negative cases in HAPI tests as applicable
@netopyr netopyr self-assigned this Jan 20, 2025
@netopyr netopyr converted this from a draft issue Jan 20, 2025
@netopyr netopyr changed the title Transaction Cleanup Accept Transaction.body and normalize transactions Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👷🏼‍♀️ In Progress
1 participant