-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use Transaction.body by default, normalize other transactions on ingest #17449
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Michael Heinrichs <[email protected]>
Signed-off-by: Michael Heinrichs <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17449 +/- ##
============================================
- Coverage 69.04% 68.94% -0.10%
+ Complexity 22789 22761 -28
============================================
Files 2619 2619
Lines 98268 98301 +33
Branches 10184 10184
============================================
- Hits 67846 67776 -70
- Misses 26597 26688 +91
- Partials 3825 3837 +12
|
Signed-off-by: Michael Heinrichs <[email protected]>
Signed-off-by: Michael Heinrichs <[email protected]>
Otherwise if a client submits a |
Signed-off-by: Michael Heinrichs <[email protected]>
Signed-off-by: Michael Heinrichs <[email protected]>
Description:
This PR simplifies the usage of
Transaction
. The fieldTransaction.body
is used by default to store theTransactionBody
. If a transaction is submitted to the network that does not follow the new standard, it is adjusted on ingest.Related issue(s):
Fixes #17448
Notes for reviewer:
Checklist